Re: [PATCH] drivers/mtd/nand/pasemi_nand.c: Add missing pci_dev_put

From: Julia Lawall
Date: Mon Dec 01 2008 - 12:39:17 EST


On Mon, 1 Dec 2008, Olof Johansson wrote:

> On Thu, Nov 27, 2008 at 01:19:49PM +0100, Julia Lawall wrote:
> > From: Julia Lawall <julia@xxxxxxx>
> >
> > pci_get_device increments a reference count that should be decremented
> > using pci_dev_put. I have thus added an extra label in the error handling
> > code to do this. I don't know, however, whether there should be a
> > pci_dev_put before the return 0 as well.
> >
> [...]
>
> > Signed-off-by: Julia Lawall <julia@xxxxxxx>
>
> Acked-by: Olof Johansson <olof@xxxxxxxxx>

Do you know the answer about the return 0?

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/