Re: [PATCH 11/32] of_platform_driver noise on sparce

[David Miller]

From: David Miller <davem@xxxxxxxxxxxxx>
Date: Wed, 26 Nov 2008 01:05:41 -0800 (PST)

Linus, just a note.

I don't know what the point of my reviewing and replying to Al's
patches is, if you're going to apply them anyways.

I also applied all of his other sparc64 patches (the ones I did think
were OK), but I did so to my sparc-next-2.6 tree, as none of this
stuff really needs to go into 2.6.28 at this point.

I've already broken sparc32 by mistake with some section annotation
"fixes" I thought were obvious.  So it's just not worth the risk in
my opinion.

And I gave suitable "applied" responses to those postings as well.

Yet you applied those to your tree directly too.

Sure, if the changes are OK, you applying them directly is fine.
But I did NAK this one specifically.

Again, just FYI...

> From: Al Viro <viro@xxxxxxxxxxxxxxxx>
> Date: Sat, 22 Nov 2008 17:35:04 +0000
> 
> > 
> > switch to __init for those; unlike powerpc sparc has no hotplug support
> > for that stuff and their ->probe() tends to call __init functions while
> > being declared __devinit.
> > 
> > Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> > ---
> >  arch/sparc64/kernel/pci_fire.c   |    2 +-
> >  arch/sparc64/kernel/pci_psycho.c |    4 ++--
> >  arch/sparc64/kernel/pci_sun4v.c  |    2 +-
> >  drivers/sbus/char/bbc_i2c.c      |    6 +++---
> >  sound/sparc/cs4231.c             |   10 +++++-----
> >  5 files changed, 12 insertions(+), 12 deletions(-)
> 
> There's tons of sparc specific drivers not handled here.
> For example, drivers/scsi/sun_esp.c, drivers/scsi/qlogicpti.c,
> and on and on and on.
> 
> In fact there are more sparc specific drivers using
> of_platform_driver under drivers/ thans powerpc :)
> 
> I don't think I want to do this for now, sorry Al.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/