Re: [PATCH] tracing/function-return-tracer: Add a barrier to ensurereturn stack index is incremented in memory

[Steven Rostedt]

On Sat, 15 Nov 2008, Frederic Weisbecker wrote:

> Impact: Fix possible race condition in ftrace function return tracer
> 
> This fixes a possible race condition if index incrementation
> is not immediately flushed in memory.
> 
> Thanks for Andi Kleen and Steven Rostedt for pointing out this issue
> and give me this solution.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Cc: Steven Rostedt <rostedt@xxxxxxxxxxx>

Acked-by: Steven Rostedt <rostedt@xxxxxxxxxxx>

-- Steve

> Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/ftrace.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c
> index fe83273..db25236 100644
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -56,6 +56,7 @@ static int push_return_trace(unsigned long ret, unsigned long long time,
>  		return -EBUSY;
>  
>  	index = ++ti->curr_ret_stack;
> +	barrier();
>  	ti->ret_stack[index].ret = ret;
>  	ti->ret_stack[index].func = func;
>  	ti->ret_stack[index].calltime = time;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/