Re: system fails to boot

From: Zhang, Yanmin
Date: Fri Nov 14 2008 - 02:22:31 EST



On Fri, 2008-11-14 at 15:22 +0900, Tejun Heo wrote:
> Alexey Dobriyan wrote:
> >> Would you like to accept the kernel patch into your testing tree? Pls. do CC to me when replying
> >> as I couldn't subscribe LKML emails now.
> >>
> >> ---
> >>
> >> --- linux-2.6.28-rc4/block/genhd.c 2008-11-11 08:37:24.000000000 +0800
> >> +++ linux-2.6.28-rc4_label/block/genhd.c 2008-11-13 04:05:35.000000000 +0800
> >> @@ -1028,6 +1028,7 @@ static int __init proc_genhd_init(void)
> >> {
> >> proc_create("diskstats", 0, NULL, &proc_diskstats_operations);
> >> proc_create("partitions", 0, NULL, &proc_partitions_operations);
> >> + register_blkdev(BLOCK_EXT_MAJOR, "blkext");
> >> return 0;
> >> }
> >> module_init(proc_genhd_init);
> >
> > It's procfs-specific init, what's up?
>
> Ah... right, better to move it to genhd_device_init(). Thanks.
Thanks. I thought nash reads /proc/devices so just added there.
Below patch moves it to ïgenhd_device_init. I tested it on my Nehalem machine.

---

--- linux-2.6.28-rc4/block/genhd.c 2008-11-14 17:20:29.000000000 +0800
+++ linux-2.6.28-rc4_boot/block/genhd.c 2008-11-14 23:11:43.000000000 +0800
@@ -768,6 +768,8 @@ static int __init genhd_device_init(void
bdev_map = kobj_map_init(base_probe, &block_class_lock);
blk_dev_init();

+ register_blkdev(BLOCK_EXT_MAJOR, "blkext");
+
#ifndef CONFIG_SYSFS_DEPRECATED
/* create top-level block dir */
block_depr = kobject_create_and_add("block", NULL);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/