Re: [PATCH] sparse_irq aka dyn_irq v13

[Ingo Molnar]

* Yinghai Lu <yinghai@xxxxxxxxxx> wrote:


> >> +     /*
> >> +      * We have to do the hash-walk again, to avoid races
> >> +      * with another CPU:
> >> +      */
> >> +     list_for_each_entry(desc, hash_head, hash_entry)
> >> +             if (desc->irq == irq)
> >> +                     goto out_unlock;

should be:

> >> +     list_for_each_entry(desc, hash_head, hash_entry) {
> >> +             if (desc->irq == irq)
> >> +                     goto out_unlock;
> >> +     }

and:

> >> +     desc = kzalloc_node(sizeof(*desc), GFP_KERNEL, node);
> >
> > Oh for gawd's sake.  PLEASE read Documentation/SubmitChecklist. 
> > Carefully.  We've already discussed this.
> >
> > You cannot do a GFP_KERNEL allocation under spin_lock_irqsave().

yes.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/