Re: [PATCH] usbmon binary format reader loses synchronization

From: Pete Zaitcev
Date: Thu Nov 13 2008 - 16:47:58 EST


On Thu, 13 Nov 2008 13:59:45 +0100, Ingo van Lil <inguin@xxxxxx> wrote:

> +++ b/drivers/usb/mon/mon_bin.c 2008-11-13 11:44:03.000000000 +0100
> @@ -681,7 +681,7 @@
> }
>
> if (rp->b_read >= sizeof(struct mon_bin_hdr)) {
> - step_len = min(nbytes, (size_t)ep->len_cap);
> + step_len = min(nbytes, sizeof(struct mon_bin_hdr) + (size_t)ep->len_cap - rp->b_read);
> offset = rp->b_out + PKT_SIZE;

I cannot tell right away if this is the best fix, but I'll look
into this. Thanks a lot!

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/