Re: [PATCH] accelerate newidle balancing in relax_domain

From: Hidetoshi Seto
Date: Thu Nov 13 2008 - 06:58:26 EST


Ingo Molnar wrote:
> I agree with making it more sensitive to momentary load fluctuations.
> (as long as other metrics do not degrade).
>
> But this solutin basically overrides the newidle_idx tuning in
> topology.h.
>
> Is there a strong reason to do this tuning dynamically, or could we
> just decrease newidle_idx in the appropriate templates in the
> topology.h files?

IMHO topology.h should have proper values that will fit 'standard'
system usage. I'm not sure that the current values (such as 2 in
SD_NODE) is best number or not... And I think it can differ by archs.

If there are no features that will be affected by the changing
default newidle_idx values, then we can fix it in the templates.
It would be a strong reason - I don't like regression :-)


Thanks,
H.Seto

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/