Re: [PATCH 2/3] 8250: Oxford Semiconductor Devices

[Alan Cox]

> > +		number_uarts = ioread8(p + 4);
> > +		board->num_ports = number_uarts;
> 
> Why not just return number of ports here ?

That would leak mappings
> 
> > +		printk(KERN_DEBUG
> > +			"%d ports detected on Oxford PCI Express device\n",
> > +								number_uarts);
> 
> Is this printk really necessary ?

For the moment yes.

> WTF is this ? Why existing pci_serial_quirks[] infrastructure cannot be used here ?

Russell already fixed that and the change went upstream.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/