Re: [rfc] x86: optimise page fault path a little
From: Andi Kleen
Date: Thu Nov 13 2008 - 03:26:32 EST
> this flow could be cleaned up further:
>
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
> [...]
> > + bad_area(regs, error_code, address);
> > + return;
>
> Any reason why that pattern shouldnt be changed to an appropriate goto
> bad_area? (probably the same goes for the nosemaphore error paths too)
The tail call is already effectively a goto.
-Andi
--
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/