Re: [PATCH 1/1] ring-buffer: buffer record on/off switch

From: Pavel Machek
Date: Wed Nov 12 2008 - 07:52:24 EST


On Tue 2008-11-11 12:56:45, Andrew Morton wrote:
> On Tue, 11 Nov 2008 15:06:02 -0500
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> > +static struct file_operations rb_simple_fops = {
>
> should be const...
>
> Probably it isn't worth fixing. Someone(tm) should do period sweeps -
> 10% of our file_operationses aren't const.

checkptch rule? struct file_operations .* = { -> needs const?

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/