Re: [PATCH 1/2] x86: Fixing improper annotation.

From: Ingo Molnar
Date: Tue Nov 11 2008 - 05:41:26 EST



* Rufus & Azrael <rufus-azrael@xxxxxxxxxxxxxx> wrote:

> Ingo Molnar wrote:
>> * Rufus& Azrael<rufus-azrael@xxxxxxxxxxxxxx> wrote:
>>
>>
>>> Hi Rakib,
>>>
>>>
>>> Your two patches set for x86 init_thread_xsate function section
>>> mismatch is correct to fix the compilation warning, but generates
>>> this other one :
>>>
>>>
>>>> WARNING: vmlinux.o(.cpuinit.text+0x7de): Section mismatch in reference
>>>> from the function xsave_cntxt_init() to the function
>>>> .init.text:__alloc_bootmem()
>>>> The function __cpuinit xsave_cntxt_init() references
>>>> a function __init __alloc_bootmem().
>>>> If __alloc_bootmem is only used by xsave_cntxt_init then
>>>> annotate __alloc_bootmem with a matching annotation.
>>>>
>>
>> that's with both 1/2 and 2/2 applied?
>>
>> Ingo
>>
>>
> Yes Ingo with the two patches applied.

okay - so i wont apply them until the full scope of the problems here
is mapped. We might be best off by marking xsave_cntxt_init() non-init
altogether for the time being?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/