Re: [PATCH] x86: Make NUMA on 32-bit depend on BROKEN

[Pavel Machek]

> From: Rafael J. Wysocki <rjw@xxxxxxx>
> Subject: x86: Make NUMA on 32-bit depend on BROKEN
> 
> While investigating the failure of hibernation on 32-bit x86 with
> CONFIG_NUMA set, as described in this message
> http://marc.info/?l=linux-kernel&m=122634118116226&w=4
> I asked some people for help and I was told that it wasn't really
> worth the effort, because CONFIG_NUMA was generally broken on 32-bit
> x86 systems and it shouldn't be used in such configs.  For this
> reason, make CONFIG_NUMA depend on BROKEN instead of EXPERIMENTAL on
> x86-32.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> Cc: Andi Kleen <andi@xxxxxxxxxxxxxx>
> Cc: Pavel Machek <pavel@xxxxxxx>

ACK.

> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> ---
>  arch/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/arch/x86/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/x86/Kconfig
> +++ linux-2.6/arch/x86/Kconfig
> @@ -957,7 +957,7 @@ config ARCH_PHYS_ADDR_T_64BIT
>  config NUMA
>  	bool "Numa Memory Allocation and Scheduler Support (EXPERIMENTAL)"
>  	depends on SMP
> -	depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_BIGSMP || X86_SUMMIT && ACPI) && EXPERIMENTAL)
> +	depends on X86_64 || (X86_32 && HIGHMEM64G && (X86_NUMAQ || X86_BIGSMP || X86_SUMMIT && ACPI) && BROKEN)
>  	default n if X86_PC
>  	default y if (X86_NUMAQ || X86_SUMMIT || X86_BIGSMP)
>  	help

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/