Re: [PATCH] Many headers included multiple times

[Andrew Morton]

On Sat, 1 Nov 2008 11:15:38 +0000
Steve Kemp <steve.30-11-2008.date@xxxxxxxxxxxx> wrote:

>  There are many source files which include the same header multiple
>  times.  Minimal initial patch included here, will submit the rest
>  shortly if there is interest.
> 
>   Quick tool to detect these: http://www.steve.org.uk/Software/kernel/

I flee in terror from patches like this because of the risk that
someone else will delete the _other_ #include, and this patch still
applies OK, so we end up removing both #includes and things break. 
This has happened before.

Thought: if the patch were to delete one #include and to then move the
other one to a different position in the #include order then this
couldn't happen.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/