Re: [PATCH 1/5] adt7462: New hwmon driver

From: Darrick J. Wong
Date: Fri Nov 07 2008 - 14:34:57 EST


On Fri, Nov 07, 2008 at 11:27:31AM -0800, Andrew Morton wrote:
> > > +#define ROUND_DIV(x, divisor) (((x) + ((divisor) / 2)) / (divisor))
> >
> > DIV_ROUND_UP ?
>
> That's different. This one should be called ROUND_CLOSEST or something
> like that.

Actually, there _is_ such a macro in include/linux/kernel.h, but it does
a double-eval naughty just like mine. That said, no need to bloat the
source tree, so I can reroll, and possibly even fix the kernel macro.

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/