Re: bdi: register sysfs bdi device only once per queue

From: Peter Zijlstra
Date: Fri Nov 07 2008 - 09:10:55 EST


On Wed, 2008-11-05 at 23:10 +0100, David Woodhouse wrote:
> On Wed, 2008-11-05 at 12:10 -0800, Andrew Morton wrote:
> > > > Devices which share the same queue, like floppies and mtd devices,
> > > > get registered multiple times in the bdi interface, but bdi accounts
> > > > only the last registered device of the devices sharing one queue.
> > >
> > > David, is there any reason the mtd devices do this?
> >
> > [tap tap - is this thing turned on?]
>
> No particular reason. It's been done that way since the dawn of time,
> when it was perfectly normal. Nobody's yet bothered to change that, when
> changing the rules.

It looks to be the consequence of using one queue for a bunch of devices
(which seems odd), and its all tied into this translation layer which
starts a thread per queue.

Do you want me to rip this up and make it do one queue/thread per
device? - seems invasive...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/