Re: [patch 2/3] x86: Add smp_mb() before sending INVALIDATE_TLB_VECTOR

From: Jens Axboe
Date: Thu Nov 06 2008 - 03:45:09 EST


On Thu, Nov 06 2008, Ingo Molnar wrote:
>
> * Suresh Siddha <suresh.b.siddha@xxxxxxxxx> wrote:
>
> > On x86, x2apic mode accesses for sending IPI's don't have
> > serializing semantics. If the IPI receiver refers(in lock-free
> > fashion) to some memory setup by the sender, the need for smp_mb()
> > before sending the IPI becomes critical in x2apic mode.
> >
> > Add the smp_mb() in native_flush_tlb_others() before sending the
> > IPI.
> >
> > Signed-off-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
>
> applied to tip/x86/urgent, thanks Suresh!
>
> Jens, you'll send 1/3 and 3/3 to Linus, right?

Yes, it's in for-linus and I'll send the pull request today.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/