Re: [PATCH 09/16] kdump: Hook emergency_virt_disable() on crashshutdown code

[Eduardo Habkost]

On Wed, Nov 05, 2008 at 09:41:44AM -0500, Vivek Goyal wrote:
> On Tue, Nov 04, 2008 at 12:52:37PM -0200, Eduardo Habkost wrote:
> > Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx>
> > ---
> >  arch/x86/kernel/crash.c |    3 +++
> >  1 files changed, 3 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c
> > index d84a852..87780ba 100644
> > --- a/arch/x86/kernel/crash.c
> > +++ b/arch/x86/kernel/crash.c
> > @@ -26,6 +26,7 @@
> >  #include <linux/kdebug.h>
> >  #include <asm/smp.h>
> >  #include <asm/reboot.h>
> > +#include <asm/virtext.h>
> >  
> >  #include <mach_ipi.h>
> >  
> > @@ -49,6 +50,7 @@ static void kdump_nmi_callback(int cpu, struct die_args *args)
> >  #endif
> >  	crash_save_cpu(regs, cpu);
> >  
> > +	emergency_virt_disable();
> >  	disable_local_APIC();
> >  }
> >  
> > @@ -80,6 +82,7 @@ void native_machine_crash_shutdown(struct pt_regs *regs)
> >  	local_irq_disable();
> >  
> >  	kdump_nmi_shootdown_cpus();
> > +	emergency_virt_disable();
> 
> Hi Eduardo,
> 
> It might be a good idea to put a 2-3 line comment saying why it is
> imporatant to disable virtualization here before we continue.

True. Sometimes I forget that detailed commit messages don't replace
good documentation on source code. I will do that.

-- 
Eduardo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/