Re: [PATCH] Use BIOS reboot on Toshiba Portege 4000

From: Avi Kivity
Date: Mon Nov 03 2008 - 05:04:20 EST


Ingo Molnar wrote:
Subject: [PATCH] Use BIOS reboot on Toshiba Portege 4000

From: Andrey Borzenkov <arvidjaar@xxxxxxx>

After commit c7ffa6c26277b403920e2255d10df849bd613380 which defaults
to reboot via ACPI keyboard is dead on Toshiba Portege 4000 upon reboot.
Power off is required to revive it again. Add DMI entry to force BIOS
reboot method as it was before.

Signed-off-by: Andrey Borzenkov <arvidjaar@xxxxxxx>

Avi, i expect more boxes to be affected by this bug, and the DMI solution just does not scale.

So could we please disable VMX from the emergency-shutdown code instead of twiddling with the reboot method?

Something like this might work as well: iff VMX is enabled, we just do smp_send_stop() (instead of skipping it) which should take care of this.

There is already some code being worked on for kdump (which suffers from the same symptoms), only kdump uses NMI IPIs for increased stopping power. Eduardo, can you take a look at porting it to emergency reboot?

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/