Re: [PATCH 2/3] HPET: Enter hpet_interrupt_handler with interrupts disabled
From: Matt Fleming
Date: Sun Nov 02 2008 - 17:23:24 EST
2008/11/2 Will Newton <will.newton@xxxxxxxxx>:
>
> Combining IRQF_DISABLED and IRQF_SHARED does not reliably disable
> interrupts in the handler. Perhaps IRQF_SHARED should be removed at
> the same time?
>
I didn't know that. Under what conditions is it unreliable?
I've attached a second attempt at this patch. It seems that the IRQ is
never shared anyway, so I followed your suggestion and removed
IRQF_SHARED. My machine seems to be running fine.