Re: 2.6.28-rc2 hates my e1000e

From: Robert Hancock
Date: Sat Nov 01 2008 - 21:27:24 EST


Linus Torvalds wrote:

On Sat, 1 Nov 2008, Jonathan Corbet wrote:
Looks to me like Linus's patch is the way to go, at least for now...

I'll make an -rc3 tomorrow. However, I suspect that if we have lots more regressions, we'll just have to revert the resource handling back to the
2.6.27 state.

The problem with resource handling is that even when we can write code that "makes sense", in the end firmware can always do odd things. For example, in your case it really does make sense to keep the already allocated PCI resources in the reserved region, because the firmware obviously did both the reserved region _and_ the PCI BAR allocation.

At the same time, I'm worried that what Windows does is something totally different, probably odd, and possibly even dependent on some HAL layer motherboard driver or other. And it's really the case that every single time we change resource allocation - never mind how subtly, or how much sense it makes - it will break some odd setup somewhere.

As far as I understand, Windows (at least with the ACPI HAL, which all remotely modern PCs will use) essentially uses the E820 map for determining usable RAM addresses only. It doesn't really care about what's reserved in that map, it expects the truly reserved ranges to be reserved as ACPI motherboard resources. (Though, it seems like it will still happily allow device BARs to overlap those ACPI reservations, at least if the BIOS put them there to start with..)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/