Re: [PATCH] rtc-ds1307: Reset bogus register values on m41t00

From: Nate Case
Date: Thu Oct 30 2008 - 17:35:05 EST


On Thu, 2008-10-30 at 15:31 -0500, Nate Case wrote:
> I'll go ahead and re-spin the patch.

After thinking about this more, I'm not sure it's right to do anything
more than the "remove legacy probe checks" patch already does. Can you
think of any harm in having the oscillator running with bogus register
values? Calls to get_time() will return -EINVAL, but that seems to be
the norm for any "bad time" condition. It makes me think that resetting
to a sane time is putting more policy than desired in the driver.

--
Nate Case <ncase@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/