Re: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register

[Cyrill Gorcunov]

[Ingo Molnar - Wed, Oct 22, 2008 at 05:04:16PM +0200]
| 
| * Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:
| 
| > [Ingo Molnar - Wed, Oct 22, 2008 at 04:59:09PM +0200]
| > | 
| > | > > | > -		apic_write(APIC_ESR, 0);
| > | > > | > -		apic_read(APIC_ESR);
| > | > > | > +		if (APIC_INTEGRATED(apic_version[phys_apicid])) {
| > | > > | > +			apic_write(APIC_ESR, 0);
| > | > > | > +			apic_read(APIC_ESR);
| > | > > | > +		}
| > | 
| > | this wouldnt build with certain configs:
| > | 
| > | arch/x86/kernel/smpboot.c: In function 'do_boot_cpu':
| > | arch/x86/kernel/smpboot.c:897: error: 'phys_apicid' undeclared (first use in this function)
| > | arch/x86/kernel/smpboot.c:897: error: (Each undeclared identifier is reported only once
| > | arch/x86/kernel/smpboot.c:897: error: for each function it appears in.)
| > | include/asm/io_32.h: In function 'memcpy_fromio':
| > | 
| > | because phys_apicid is not available in the !WAKE_SECONDARY_VIA_INIT 
| > | case. Changed it to boot_cpu_physical_apicid - that should be good 
| > | enough.
| > | 
| > | 	Ingo
| > | 
| > 
| > Did you fixed it? (oh... actually I've been compilling the patch
| > but had this CONFIG turned on and didn't catch this issue)
| 
| yeah, fixed it up, dont worry about it.
| 
| 	Ingo
| 

Thanks Ingo!

		- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/