Re: [PATCH] documentation: explain memory barriers

[Andrew Morton]

On Wed, 08 Oct 2008 21:17:58 -0400 Chris Snook <csnook@xxxxxxxxxx> wrote:

> Randy Dunlap wrote:
> > On Wed, 1 Oct 2008 22:54:04 -0700 Andrew Morton wrote:
> > 
> >> This sequence is repeated three or four times and should be pulled out
> >> into a well-commented function.  That comment should explain the logic
> >> behind the use of these barriers, please.
> > 
> > and on 2008-OCT-08 Ben Hutchings wrote:
> > 
> >> All memory barriers need a comment to explain why and what they're doing.

I approve this message.

> Seriously?  When a barrier is used, it's generally self-evident what 
> it's doing.

fs/buffer.c:sync_buffer().  Have fun.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/