Re: [PATCH] sky2: Fix recent WOL regression

From: David Miller
Date: Wed Oct 08 2008 - 19:12:52 EST


From: "Rafael J. Wysocki" <rjw@xxxxxxx>
Date: Thu, 9 Oct 2008 00:55:55 +0200

> On Friday, 3 of October 2008, Stephen Hemminger wrote:
> > On Thu, 2 Oct 2008 23:39:33 +0200
> > "Rafael J. Wysocki" <rjw@xxxxxxx> wrote:
> >
> > > From: Rafael J. Wysocki <rjw@xxxxxxx>
> > >
> > > sky2: Fix recent WOL regression
> > >
> > > Since dev->power.should_wakeup bit is used by the PCI core to
> > > decide whether the device should wake up the system from sleep
> > > states, set/unset this bit whenever WOL is enabled/disabled using
> > > sky2_set_wol() (this fixes a regression from 2.6.26 on the Tino's
> > > machine).
> > >
> > > Remove an open-coded reference to the standard PCI PM registers that
> > > is not used any more.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rjw@xxxxxxx>
> > > Reported-by: Tino Keitel <tino.keitel@xxxxxx>
> > > ---
> >
> > Acked-by: Stephen Hemminger <shemminger@xxxxxxxxxx>
> >
> > Thanks for fixing this.
>
> Can you please include this patch into your next push for Jeff?
>
> It seems to have been overlooked.

I missed this ACK but I did add the patch to my tree as you
can see from another email of mine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/