Re: [PATCH 6/9] x86/iommu: change Calgary to use dma_ops registerinterface

[Ingo Molnar]

* Muli Ben-Yehuda <muli@xxxxxxxxxx> wrote:

> > > +static int calgary_device_supported(struct device *dev)
> > > +{
> > > +	return translation_enabled(find_iommu_table(dev));
> > > +}
> 
> Sure, but I prefer the explicit form since it lends itself to easier
> debugging (oops line numbers, adding printks, etc.).

we never do that for simple stuff like this. The kernel would be twice 
as large if we did. An oops is easy enough to decode and an oops does 
not come with a line number.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/