Re: [PATCH 2/6] Unified trace buffer

From: Ingo Molnar
Date: Tue Sep 30 2008 - 05:45:50 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> +void ring_buffer_lock(struct ring_buffer *buffer, unsigned long *flags)
> +{
> + struct ring_buffer_per_cpu *cpu_buffer;
> + int cpu;
> +
> + local_irq_save(*flags);
> +
> + for_each_buffer_cpu(buffer, cpu) {
> + cpu_buffer = buffer->buffers[cpu];
> + spin_lock(&cpu_buffer->lock);
> + }
> +}

hm, that's rather unintelligent and needs to be fixed.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/