Re: [PATCH 05/31] cpumask: Provide new cpumask API
From: Ingo Molnar
Date: Tue Sep 30 2008 - 05:12:23 EST
* Mike Travis <travis@xxxxxxx> wrote:
> /* replaces cpumask_t dst = (cpumask_t)src */
> void cpus_copy(cpumask_t dst, const cpumask_t src);
minor namespace nit i noticed while looking at actual usage of
cpus_copy(): could you please rename it cpumask_set(dst, src)?
That streamlines it to have the same naming concept as atomic_set(),
node_set(), zero_fd_set(), etc.
the patch-set looks quite nice otherwise already, the changes are
straightforward and the end result already looks a lot more maintainable
and not fragile at all.
In what way will Rusty's changes differ? Since you incorporate some of
Rusty's changes already, could you please iterate towards a single
patchset which we could then start testing?
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/