Re: [patch 2/2] x86: Handle error returns in set_memory_*

From: Frans Pop
Date: Tue Sep 30 2008 - 04:36:50 EST


Ingo Molnar wrote:
> * Venkatesh Pallipadi <venkatesh.pallipadi@xxxxxxxxx> wrote:
>> Correctly handle the error returns from set_memory_*. We have to free
>> memtype on error return path.
>
> we should emit a kernel warning as well if any of those calls fail.
> Drivers should not be randomly poking on RAM ranges.

Has this comment from Ingo been addressed already?

> i'm also missing some background on this, could you please explain in a
> bit more detail about what errors there were triggered, and how they
> caused the display artifacts?

I would be interested in this as well.

As I mentioned before, I only tested with the first of the two patches
(as you asked me to) and that solved the artifacts for me. What's the
explanation behind that?

What is the relationship between the first and second patch?

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/