Re: [PATCH] Markers : fix reentrancy

From: Ingo Molnar
Date: Tue Sep 30 2008 - 03:10:29 EST



* Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx> wrote:

> Lai Jiangshan <laijs@xxxxxxxxxxxxxx> wrote :
> > marker_synchronize_unregister must be called _also_ between unregistration
> > and destruction the data that unregistration-ed probes need to make sure
> > there is no caller executing a probe when it's data is destroyed.
> >
>
> Ah, you're right. I looked again through your patch description and I
> think using a :
>
>
> if (entry->rcu_pending)
> rcu_barrier_sched();
>
> After each time the markers_mutex is taken would keep the fast batch
> registration/unregistration and fix the reentrancy problem. The
> following patch should address the problem.

could you please send a delta patch against tip/master? Lai's patch is
already applied and is tested. Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/