Re: [PATCH] markers: let marker_debug as module parameter

[Mathieu Desnoyers]

* Lai Jiangshan (laijs@xxxxxxxxxxxxxx) wrote:
> 
> if we want to enable marker debug output, we have to modify
> the code and remake/reinstall the kernel in current code.
> 
> this patch enable marker_debug to be set when kernel start.
> 

Given it's only called at probe registration/unregistration and never
put in the critical path of an executed marker, it makes sense to make
this a kernel arg debug option. I like this patch :)

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxx>

> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
> ---
> diff --git a/kernel/marker.c b/kernel/marker.c
> index 9f76c4a..5d8404f 100644
> --- a/kernel/marker.c
> +++ b/kernel/marker.c
> @@ -28,8 +28,9 @@
>  extern struct marker __start___markers[];
>  extern struct marker __stop___markers[];
>  
> -/* Set to 1 to enable marker debug output */
> -static const int marker_debug;
> +static int marker_debug;
> +module_param(marker_debug, bool, 0);
> +MODULE_PARM_DESC(marker_debug, "Set to 1 to enable marker debug output");
>  
>  /*
>   * markers_mutex nests inside module_mutex. Markers mutex protects the builtin
> 
> 

-- 
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/