Re: [PATCH 01/19] pci: introduce an pci_ioremap(pdev, barnr)function

[Alan Cox]

> > This is the same like pci_iomap(pdev, number, 0), no?
> 
> Yeah... Looks like that function isn't that widely used though.  Is the maxlen 
> param really needed?  Looks like the drivers that use it often pass 0 or the 

In some cases yes you do need the length.

> BAR length anyway, and Arjan converted existing drivers too, which is where 
> the real work is.

He could have converted them to the existing perfectly good API not
invented another one. He still can - I'm sure its a perl one liner to
redo them in terms of pci_iomap()

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/