Re: [PATCH] pci: introduce users of ioremap_pcibar()

From: Arjan van de Ven
Date: Mon Sep 29 2008 - 13:23:27 EST


On Mon, 29 Sep 2008 11:10:49 -0600
Grant Grundler <grundler@xxxxxxxxxxxxxxxx> wrote:

> And I have to agree with willy/alan, pci_iomap() is already doing
> this.

pci_iomap() does "stuff" but it assumes you're using the iomap APIs
across the driver. MANY don't.

And pci_iomap() takes more parameters than most driver writers want or
need. Most of the time it's "I want the whole bar"; even if my patch
wraps around that, making the API simpler is still worth it imo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/