Re: scatterlist.c: bug in sg_next()?

[Leon Woestenberg]

Hello,

On Sun, Sep 28, 2008 at 5:28 PM, Boaz Harrosh <bharrosh@xxxxxxxxxxx> wrote:
> Leon Woestenberg wrote:
>> In sg_next(), after following a chain_ptr, a few more checks should be
>> performed.
>> The rare case exists that the first entry in the chained list is a
>> last marker, in case NULL must be returned.
>
> No! the last marker is set on a valid sg entry. Only it's next
> is no longer valid. So the check at the top is for the Next-sg
> not the passed-in-sg. What you thought of is a NULL terminating
> sg-list. The end marker is so to save the extra NULL entry.
>
Ah yes, the lower bit magic. Thanks!

Sorry for the noise.

Regards,
-- 
Leon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/