Re: [PATCH] PCIE: use PCI_EXT_CAP_NEXT to traverse PCIE extendedcapability list.

From: Zhang, Yanmin
Date: Sun Sep 28 2008 - 03:23:52 EST



On Sun, 2008-09-28 at 13:07 +0800, qingtao.cao@xxxxxxxxxxxxx wrote:
> PCIE extended capability unit is of 4-byte, so the least 2 bits of the most
> significant 12 bits should be masked off to zero when accessing the extended
> capability list.
>
> Signed-off-by: Harry Ciao<qingtao.cao@xxxxxxxxxxxxx>
ïAcked-by: ïZhang Yanmin <yanmin_zhang@xxxxxxxxxxxxxxx>

> ---
> drivers/pci/pcie/aer/aerdrv_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/pci/pcie/aer/aerdrv_core.c
> +++ b/drivers/pci/pcie/aer/aerdrv_core.c
> @@ -52,7 +52,7 @@
> if (PCI_EXT_CAP_ID(reg32) == PCI_EXT_CAP_ID_ERR)
> break;
>
> - pos = reg32 >> 20;
> + pos = PCI_EXT_CAP_NEXT(reg32);
> }
>
> return pos;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/