Re: [PATCH 3/12] memcg make root cgroup unlimited.

From: KAMEZAWA Hiroyuki
Date: Fri Sep 26 2008 - 05:14:53 EST


On Fri, 26 Sep 2008 14:11:00 +0530
Balbir Singh <balbir@xxxxxxxxxxxxxxxxxx> wrote:

> KAMEZAWA Hiroyuki wrote:
> > Make root cgroup of memory resource controller to have no limit.
> >
> > By this, users cannot set limit to root group. This is for making root cgroup
> > as a kind of trash-can.
> >
> > For accounting pages which has no owner, which are created by force_empty,
> > we need some cgroup with no_limit. A patch for rewriting force_empty will
> > will follow this one.
> >
> > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
>
> This is an ABI change (although not too many people might be using it, I wonder
> if we should add memory.features (a set of flags and let users enable them and
> provide good defaults), like sched features.
>
I think "feature" flag is complicated, at this stage.
We'll add more features and not settled yet.

Hmm, if you don't like this,
calling try_to_free_page() at force_empty() instead of move_account() ?


Thanks,
-Kame

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/