Re: [PATCH] PM: use pm_op methods for device types

From: Greg KH
Date: Thu Sep 25 2008 - 18:09:41 EST


On Thu, Sep 25, 2008 at 11:27:02PM +0200, Rafael J. Wysocki wrote:
> On Thursday, 25 of September 2008, Alan Stern wrote:
> > This patch (as1141) adds code to use the device type's pm_op methods,
> > if they are defined. It fixes a regression in the USB PM code; the
> > various suspend and resume methods are defined in the device type
> > rather than in the bus, because USB devices have to be handled
> > differently from USB interfaces. Without the patch, those methods
> > never get called.
> >
> > The patch also fixes a couple of spelling errors.
>
> Hm, these changes are not needed in the current mainline, so there's a patch
> in -next that removes the code added by this patch.
>
> It might be better to find that patch and drop it instead, IMO.

I agree, I think we would have seen more bugs if mainline can't suspend
with a USB device attached, right?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/