Re: [PATCH v2] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

From: Scott Wood
Date: Thu Sep 25 2008 - 14:40:35 EST


On Thu, Sep 25, 2008 at 08:54:30AM -0500, Timur Tabi wrote:
> Li Yang wrote:
>
> >> -subsys_initcall(of_fsl_dma_chan_init);
> >> subsys_initcall(of_fsl_dma_init);
> >
> > Not a critical problem. But module_init() are preferred for modules.
>
> This was intentional. When compiled as a module, subsys_initcall becomes
> module_init(). When compiled in-kernel, this code is initialized before most
> drivers, so it's ready when the drivers are loaded.

If there's a dependency there, how will it work when this is built as a
module?

-Scott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/