Re: [PATCH 3/3] e1000e: remove failed request for sw/fw/hw flag

From: Jiri Kosina
Date: Wed Sep 24 2008 - 21:02:51 EST


On Wed, 24 Sep 2008, Jeff Garzik wrote:

> > When the driver fails to acquire the control flag used to serialize
> > NVM and PHY accesses between the driver, firmware and hardware, remove the
> > request for the flag otherwise the hardware might grant the flag when it
> > becomes available but the driver will not release the flag. This could
> > cause the firmware to prevent the driver getting the flag for all future
> > attempts.
> applied

BTW are you going to take the whole series, or just this fix?

I don't think that the other patches should be really applied to upstream
(they could be very handy for debugging this horrible issue, once we could
do any debugging of it, thoug), as they don't protect against anyone
creating a new rw mapping, which can then be freely used to still
overwrite the mmio area without any problems.

--
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/