Re: [PATCH] fsl-dma: allow Freescale Elo DMA driver to be compiled as a module

[Dan Williams]

On Mon, Sep 22, 2008 at 1:59 PM, Timur Tabi <timur@xxxxxxxxxxxxx> wrote:
> Dan Williams wrote:
>
>> The last three hunks should be broken out into a separate 'fix' patch
>> with its own changelog.
>
> Can you be more specific?  I can see how "return 0" -> "return -ENOMEM" could be
> separated out, but the Kconfig hunk is integral to the patch, and the "if
> (fsl_chan->desc_pool) return 1;" is needed to prevent a memory leak if the
> module is unloaded.
>

Sorry, I miscounted.  I was indeed referring to the just the "return 0
--> return -ENOMEM" fix.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/