Re: Re: [PATCH 4/13] memcg: force_empty moving account

[Peter Zijlstra]

On Mon, 2008-09-22 at 23:50 +0900, kamezawa.hiroyu@xxxxxxxxxxxxxx wrote:
> ----- Original Message -----
> >> +			spin_lock_irqsave(&mz->lru_lock, flags);
> >> +		} else {
> >> +			unlock_page(page);
> >> +			put_page(page);
> >> +		}
> >> +		if (atomic_read(&mem->css.cgroup->count) > 0)
> >> +			break;
> >>  	}
> >>  	spin_unlock_irqrestore(&mz->lru_lock, flags);
> >
> >do _NOT_ use yield() ever! unless you know what you're doing, and
> >probably not even then.
> >
> >NAK!
> Hmm, sorry. cond_resched() is ok ?

depends on what you want to do, please explain what you're trying to do.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/