Re: [Bug #11382] e1000e: 2.6.27-rc1 corrupts EEPROM/NVM

[David Miller]

From: "Rafael J. Wysocki" <rjw@xxxxxxx>
Date: Sun, 21 Sep 2008 20:54:13 +0200 (CEST)

> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=11382
> Subject		: e1000e: 2.6.27-rc1 corrupts EEPROM/NVM
> Submitter	: David Vrabel <david.vrabel@xxxxxxx>
> Date		: 2008-08-08 10:47 (45 days old)
> References	: http://marc.info/?l=linux-kernel&m=121819267211679&w=4
> Handled-By	: Christopher Li <chrisl@xxxxxxxxxx>

Fixed by:

commit 78566fecbb12a7616ae9a88b2ffbc8062c4a89e3
Author: Christopher Li <chrisl@xxxxxxxxxx>
Date:   Fri Sep 5 14:04:05 2008 -0700

    e1000: prevent corruption of EEPROM/NVM
    
    Andrey reports e1000 corruption, and that a patch in vmware's ESX fixed
    it.
    
    The EEPROM corruption is triggered by concurrent access of the EEPROM
    read/write. Putting a lock around it solve the problem.
    
    [akpm@xxxxxxxxxxxxxxxxxxxx: use DEFINE_SPINLOCK to avoid confusing lockdep]
    Signed-off-by: Christopher Li <chrisl@xxxxxxxxxx>
    Reported-by: Andrey Borzenkov <arvidjaar@xxxxxxx>
    Cc: Zach Amsden <zach@xxxxxxxxxx>
    Cc: Pratap Subrahmanyam <pratap@xxxxxxxxxx>
    Cc: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
    Cc: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
    Cc: Bruce Allan <bruce.w.allan@xxxxxxxxx>
    Cc: PJ Waskiewicz <peter.p.waskiewicz.jr@xxxxxxxxx>
    Cc: John Ronciak <john.ronciak@xxxxxxxxx>
    Cc: Jeff Garzik <jeff@xxxxxxxxxx>
    Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
    Signed-off-by: Jeff Garzik <jgarzik@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/