Re: [PATCH] x86: c1e_idle: don't mark TSC unstable if CPU hasinvariant TSC

[Ingo Molnar]

* Andreas Herrmann <andreas.herrmann3@xxxxxxx> wrote:

> Currently the kernel assumes TSC is stable and there are various 
> places where Linux might spot when TSC is unstable. c1e_idle is one 
> such place. But it's wrong to mark TSC unstable for all AMD CPUs in 
> this function as newer CPU families have TSC's that are P- and C-state 
> invariant.

i agree with the purpose of the patch (as it flags the first really sane 
TSC implementation on x86!!!) - but it would be nice to indicate this in 
a different CPU feature bit other than X86_FEATURE_CONSTANT_TSC, to 
reduce confusion. Perhaps introduce a virtual CPU feature bit for that?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/