Re: [PATCH 3/6] pci: using printk(KERN_PCI v3

[Robert Richter]

On 17.09.08 01:41:03, Yinghai Lu wrote:
> On Wed, Sep 17, 2008 at 1:35 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > * Yinghai Lu <yhlu.kernel@xxxxxxxxx> wrote:
> >
> >> -                     printk(KERN_DEBUG "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
> >> +                     printk(KERN_DEBUG KERN_PCI
> >> +                              "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
> >
> > i think we should aim to make the common usage of this facility as easy
> > and short as possible. That means that i think the right line is:
> >
> > +                       printk(KERN_PCI
> > +                                "PCI: %s reg %x 64bit mmio: [%llx, %llx]\n",
> >
> > as that is the shortest form. KERN_PCI should imply whatever
> > common-sense default. It should still make sense to specify KERN_FOO
> > KERN_PCI, to override that default.
> 
> vprintk will add default before that like
> like print(KERN_INFO KERN_PCI ....)

What about a pci_dbg() macro similiar to dev_dbg()? Same could be used
for ACPI, acpi_dbg().

-Robert

> 
> YH
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@xxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/