Re: [RFC PATCH 0/1]: timers: Timer Migration

From: Arjan van de Ven
Date: Tue Sep 16 2008 - 09:53:58 EST


On Tue, 16 Sep 2008 14:42:31 +0530
Arun R Bharadwaj <arun@xxxxxxxxxxxxxxxxxx> wrote:

> Hi,
>
> An idle cpu on which device drivers have initialized timers, has to
> be frequently woken up to service the timers. So, consolidation of
> timers onto a fewer number of cpus is important. Migration of timers
> from idle cpus onto lesser idle cpus is necessary. Currently, timers
> are migrated during the cpu offline operation. However cpu-hotplug
> for the sake of idle system power management is too heavy. So, this
> patch implements a lightweight timer migration framework.

while I absolutely like reducing power consumption... I'm not sure this
helps or is the right approach.

First of all, it's of course absolutely better to fix timers and apps
that cause them (and with PowerTOP we fixed basically all the bad
stuff).

Second, in terms of power; a wake up is a wake up, it doesn't really
matter where it happens.

Now we could do some consolidation (which realistically needs the range
timer feature that's aimed for 2.6.28), but I would much rather do that
in a different way: rather than actively moving stuff, I would instead
suggest sharing the timer queues between logical cpus that share the
same cache. (Now its an admin choice if he wants this on a "shared L1",
"shared L2" or "shared L3" basis).

Or if you want to forcefully migrate timers, don't move existing ones,
just on queue/requeue put the on not-the-local-cpu. Sure they'll fire
once on the "wrong" cpu, but that's a very short term problem!

--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/