Re: + itimers-fix-itimer-many-thread-hang.patch added to -mm tree

From: Oleg Nesterov
Date: Tue Sep 16 2008 - 07:07:38 EST


On 09/15, Frank Mayhar wrote:
>
> I have a few more things to do; expect a new iteration of the patch
> tonight or tomorrow.

Great.

Please also remove tasklist_lock from thread_group_cputime_alloc_smp(),
it is not needed.

I'd also suggest to kill

if (sig->cputime.totals)
return 0;

, the caller has already checked this.


Please note also that thread_group_cputime_clone_thread() doesn't need
the second argument.


Very minor nit, but thread_group_cputime_alloc_smp() doesn't really
need get_cpu() + put_cpu_no_resched(), it can use smp_processor_id().

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/