Re: [patch 3/3] x86: io-apic - code style cleaning forsetup_IO_APIC_irqs

From: Cyrill Gorcunov
Date: Sat Sep 06 2008 - 16:13:45 EST


[Maciej W. Rozycki - Sat, Sep 06, 2008 at 09:08:51PM +0100]
| On Sat, 6 Sep 2008, Cyrill Gorcunov wrote:
|
| > So I think better would be just use Ingo's suggestion
| > about to separate apic/pin iterator and function body.
|
| No doubt about it. Then if the number of entries was to be huge, then
| lines output to the log buffer could be limited to 80 characters. With
| the use of sprintf() it would be rather trivial. And you would avoid any
| concerns about stack consumption.
|
| Please note that with MPS 1.1 systems the number of "unconnected" I/O
| APIC inputs can be considerable.
|
| Maciej
|

Thanks Maciej, will continue tomorrow.

- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/