Re: [PATCH] kernel/cpu.c: Move the CPU_DYING notifiers

[Ingo Molnar]

* Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> wrote:

> Ingo Molnar wrote:
>> * Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> wrote:
>>   
>>> -	raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>>> -				param->hcpu);
>>>  	/* Ensure this CPU doesn't handle any more interrupts. */
>>>  	err = __cpu_disable();
>>>  	if (err < 0)
>>>  		return err;
>>>  +	raw_notifier_call_chain(&cpu_chain, CPU_DYING | param->mod,
>>> +				param->hcpu);
>>>     
>>
>> hm, doesnt this break things like CPU cross-calls done in CPU_DYING  
>> callbacks?
>>   
>
> We are within stop_machine(). No other cpu is running. As fas as I can 
> see no cross-calls are possible.

ah, ok - my bad. I was confusing it with the much more common 
CPU_DOWN_PREPARE type of callbacks which do use various cross-CPU APIs.

applied to tip/sched/devel, thanks Manfred!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/