Re: [PATCH 02/23] arm: use the new byteorder headers

[Russell King]

On Fri, Sep 05, 2008 at 03:06:06PM +0100, David Woodhouse wrote:
> On Fri, 2008-09-05 at 11:25 +0100, Russell King wrote:
> > On Fri, Sep 05, 2008 at 10:49:29AM +0100, David Woodhouse wrote:
> > > On Tue, 2008-08-19 at 12:03 -0700, Harvey Harrison wrote:
> > > > include/linux/swab.h, include/linux/byteorder.h are in current
> > > > mainline which is all that these patches depend on.
> > > 
> > > Er, it also depends on the patch which exports those headers to
> > > userspace, which isn't in Linus' tree yet.
> > 
> > How useful.  If those generic headers are already in Linus' tree, and
> > are required for architectures to convert, why hasn't the patch which
> > exports them to userspace already been submitted?
> 
> Because they weren't being used by anything exported to userspace yet.
> The patch has been seen, but wasn't destined for 2.6.27...
>
> > However, another question: why should userspace be using a kernel header
> > file for byteswapping?
> 
> ... mostly (on my part, at least) because of that question.
> 
> Given my druthers, I'd revert the ARM part of the patch for now, and we
> can have a _serious_ think about whether we really need to export these
> functions to userspace.

I'll revert it, and if it's resubmitted, I'll ignore it until after the
next merge window - since my tree for the upcoming merge window currently
pre-dates the revert, so effectively continues to carry it until it's
merged.

I'm not sure what went wrong, other than being continuously bugged by
Harvey to apply his patch.  If his patches are inappropriate, surely
that should've been pointed out to Harvey before he got the first of
his series merged?

Maybe more of his patches need reverting if some have been applied?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/