Re: [alsa-devel] [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver

From: Mark Brown
Date: Fri Sep 05 2008 - 09:11:05 EST


On Fri, Sep 05, 2008 at 06:21:35PM +0800, Bryan Wu wrote:

> + /* Maybe the dummy buffer descriptor ring is damaged */
> + sport->dummy_rx_desc->next_desc_addr = \
> + (unsigned long)(sport->dummy_rx_desc+1);

Here and elsewhere in this driver you've got continuation characters
which aren't need. I've fixed this up locally (and some additional
checkpatch/coding standards things) here and in other patches in the
series.

Otherwise the patch series looks good to go, thanks - I'm just about to
review the codec driver patch that it depends upon.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/