Re: [Patch] Tracing/ftrace: Adds a marker to allow user comments

From: Frédéric Weisbecker
Date: Thu Sep 04 2008 - 12:20:28 EST


2008/8/28 Pekka Paalanen <pq@xxxxxx>:
> Yes, but the atmosphere is that if there are no users in-tree, the feature
> gets kicked, out-of-tree users or no. That's the reason mmiotrace went
> in-tree in the first place. So, to get that stuff exported, we might need
> in-tree users, I believe.

Perhaps it should be more discussed because it is an unsual case...

Ok so just a question before I start a new patch to correct the marker's file.

What is the best way to implement tracers's printk handlers?
Do you think that these functions must be implemented in trace.c or is
it more relevant to dispatch the message to
a function provided by the current tracer in its struct tracer
operations? If such handler is not implemented, we just defaults the
formatting like ftrace_printk does.

Thanks...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/